lkml.org 
[lkml]   [2021]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] libnvdimm, badrange: replace div_u64_rem with DIV_ROUND_UP
From
Date

A gentle ping

on 2021/6/26 11:53, Kemeng Shi wrote:
> __add_badblock_range use div_u64_rem to round up end_sector and it
> will introduces unnecessary rem define and costly '%' operation.
> So clean it with DIV_ROUND_UP.
>
> Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
> ---
> V1->V2:
> -- fix that end_sector is assigned twice, sorry for that.
>
> drivers/nvdimm/badrange.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/nvdimm/badrange.c b/drivers/nvdimm/badrange.c
> index aaf6e215a8c6..af622ae511aa 100644
> --- a/drivers/nvdimm/badrange.c
> +++ b/drivers/nvdimm/badrange.c
> @@ -187,12 +187,9 @@ static void __add_badblock_range(struct badblocks *bb, u64 ns_offset, u64 len)
> const unsigned int sector_size = 512;
> sector_t start_sector, end_sector;
> u64 num_sectors;
> - u32 rem;
>
> start_sector = div_u64(ns_offset, sector_size);
> - end_sector = div_u64_rem(ns_offset + len, sector_size, &rem);
> - if (rem)
> - end_sector++;
> + end_sector = DIV_ROUND_UP(ns_offset + len, sector_size);
> num_sectors = end_sector - start_sector;
>
> if (unlikely(num_sectors > (u64)INT_MAX)) {
>

--
Best wishes
Kemeng Shi

\
 
 \ /
  Last update: 2021-07-08 15:12    [W:0.077 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site