Messages in this thread | | | Date | Thu, 8 Jul 2021 13:08:07 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH] tracing/selftests: Add tests to test histogram sym and sym-offset modifiers |
| |
On Wed, 7 Jul 2021 12:14:51 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org> > > Add a test to the tracing selftests that will catch if the .sym or > .sym-offset modifiers break in the future. > > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
> --- > .../ftrace/test.d/trigger/trigger-hist.tc | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc > index 2950bfbc6fce..adae72665500 100644 > --- a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc > +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc > @@ -39,6 +39,24 @@ grep "parent_comm: $COMM" events/sched/sched_process_fork/hist > /dev/null || \ > > reset_trigger > > +echo "Test histogram with sym modifier" > + > +echo 'hist:keys=call_site.sym' > events/kmem/kmalloc/trigger > +for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done > +grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]* *}' events/kmem/kmalloc/hist > /dev/null || \ > + fail "sym modifier on kmalloc call_site did not work" > + > +reset_trigger > + > +echo "Test histogram with sym-offset modifier" > + > +echo 'hist:keys=call_site.sym-offset' > events/kmem/kmalloc/trigger > +for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done > +grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]*+0x[0-9a-f][0-9a-f]*' events/kmem/kmalloc/hist > /dev/null || \ > + fail "sym-offset modifier on kmalloc call_site did not work" > + > +reset_trigger > + > echo "Test histogram with sort key" > > echo 'hist:keys=parent_pid,child_pid:sort=child_pid.ascending' > events/sched/sched_process_fork/trigger > -- > 2.31.1 >
-- Masami Hiramatsu <mhiramat@kernel.org>
| |