lkml.org 
[lkml]   [2021]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] ARM: dts: imx7d-remarkable2: Add WiFi support
On Tue, Jul 6, 2021 at 10:29 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Alistair,
>
> On Tue, Jul 6, 2021 at 8:40 AM Alistair Francis <alistair@alistair23.me> wrote:
>
> > + wifi_pwrseq: wifi_pwrseq {
> > + compatible = "mmc-pwrseq-simple";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_wifi>;
> > + reset-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> > + clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
>
> Don't you need to select the osc32 as the parent clock?
>
> This is what we do on arch/arm/boot/dts/imx7d-pico.dtsi and
> arch/arm/boot/dts/imx7d-nitrogen7.dts:
>
> &clks {
> assigned-clocks = <&clks IMX7D_CLKO2_ROOT_SRC>,
> <&clks IMX7D_CLKO2_ROOT_DIV>;
> assigned-clock-parents = <&clks IMX7D_CKIL>;
> assigned-clock-rates = <0>, <32768>;
> };

I'm not sure I follow, we do the same thing here with:

&clks {
assigned-clocks = <&clks IMX7D_CLKO2_ROOT_SRC>,
<&clks IMX7D_CLKO2_ROOT_DIV>;
assigned-clock-parents = <&clks IMX7D_CKIL>;
assigned-clock-rates = <0>, <32768>;
};

Alistair

\
 
 \ /
  Last update: 2021-07-08 11:17    [W:0.055 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site