Messages in this thread Patch in this message | | | From | Nishanth Menon <> | Subject | [PATCH] scripts/spdxcheck-test.sh: Drop python2 | Date | Wed, 7 Jul 2021 16:06:00 -0500 |
| |
Since commit d0259c42abff ("spdxcheck.py: Use Python 3"), spdxcheck.py explicitly expects to run as python3 script, there is no further point in attempting to test with python2.
Cc: Bert Vermeulen <bert@biot.com> Signed-off-by: Nishanth Menon <nm@ti.com> ---
Also see checkpatch.pl patch https://lore.kernel.org/lkml/20210505211720.447111-1-linux@roeck-us.net/
PS: While it may be debatable if *ever* there is going to be a python4 and hence leave the for loop alone (in addition to reducing the diffstat). I just took the path where I hope if we ever see that day, we pick one version.
scripts/spdxcheck-test.sh | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/scripts/spdxcheck-test.sh b/scripts/spdxcheck-test.sh index cfea6a0d1cc0..cb76324756bd 100644 --- a/scripts/spdxcheck-test.sh +++ b/scripts/spdxcheck-test.sh @@ -1,12 +1,10 @@ #!/bin/sh -for PYTHON in python2 python3; do - # run check on a text and a binary file - for FILE in Makefile Documentation/logo.gif; do - $PYTHON scripts/spdxcheck.py $FILE - $PYTHON scripts/spdxcheck.py - < $FILE - done - - # run check on complete tree to catch any other issues - $PYTHON scripts/spdxcheck.py > /dev/null +# run check on a text and a binary file +for FILE in Makefile Documentation/logo.gif; do + python3 scripts/spdxcheck.py $FILE + python3 scripts/spdxcheck.py - < $FILE done + +# run check on complete tree to catch any other issues +python3 scripts/spdxcheck.py > /dev/null -- 2.32.0
| |