lkml.org 
[lkml]   [2021]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] ucounts: Fix UCOUNT_RLIMIT_SIGPENDING counter leak
    On Wed, Jul 7, 2021 at 9:50 AM Alexey Gladkov <legion@kernel.org> wrote:
    >
    > > + dec_rlimit_ucounts(ucounts, UCOUNT_RLIMIT_SIGPENDING, 1);
    > > + fallthrough;
    > > + case LONG_MAX:
    >
    > I think that the counter should be decreased in this case too.
    > inc_rlimit_ucounts() increments the counter in all parent userns. If we
    > don't decrease the counter then the parent userns will have a counter
    > leak.

    Ack. So basically that patch, but move the dec_rlimit_ucounts() into
    the LONG_MAX case?

    Would you mind making a real patch with a commit message, and trying
    whatever test-case you had for that KASAN use-after-free report?

    Linus

    \
     
     \ /
      Last update: 2021-07-07 19:24    [W:7.041 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site