Messages in this thread | | | Date | Wed, 7 Jul 2021 17:22:06 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 04/12] ASoC: amd: create acp5x platform devices |
| |
On Wed, Jul 07, 2021 at 11:26:15AM +0530, Vijendar Mukunda wrote:
> +#define I2S_MODE 0x00 > +#define ACP5x_I2S_MODE 0x00
All the other constants are namespaced so why the plain I2S_MODE?
> + val = acp_readl(adata->acp5x_base + ACP_PIN_CONFIG); > + switch (val) { > + case I2S_MODE:
...
> + break; > + default: > + dev_info(&pci->dev, "ACP audio mode : %d\n", val); > + }
Given that anything other than I2S is basically unhandled should we perhaps print an error rather than just an info message? [unhandled content-type:application/pgp-signature] | |