lkml.org 
[lkml]   [2021]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] net: core: fix SO_TIMESTAMP_* option setting
On Wed, Jul 7, 2021 at 11:27 AM Sergei Trofimovich <slyfox@gentoo.org> wrote:
>
> I noticed the problem as a systemd-timesyncd (and ntpsec) sync failures:
>
> systemd-timesyncd[586]: Timed out waiting for reply from ...
> systemd-timesyncd[586]: Invalid packet timestamp.
>
> Bisected it down to commit 371087aa476
> ("sock: expose so_timestamp options for mptcp").
>
> The commit should be a no-op but it accidentally reordered option type
> and option value:
>
> +void sock_set_timestamp(struct sock *sk, int optname, bool valbool);
> ...
> - __sock_set_timestamps(sk, valbool, true, true);
> + sock_set_timestamp(sk, valbool, optname);
>
> Tested the fix on systemd-timesyncd. The sync failures went away.
>
> CC: Paolo Abeni <pabeni@redhat.com>
> CC: Florian Westphal <fw@strlen.de>
> CC: Mat Martineau <mathew.j.martineau@linux.intel.com>
> CC: David S. Miller <davem@davemloft.net>
> CC: Jakub Kicinski <kuba@kernel.org>
> CC: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---

I think this has been fixed five days ago in

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=81b4a0cc7565b08cadd0d02bae3434f127d1d72a

\
 
 \ /
  Last update: 2021-07-07 14:35    [W:0.047 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site