lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.12 025/160] drm/virtio: Fix double free on probe failure
    Date
    From: Xie Yongji <xieyongji@bytedance.com>

    [ Upstream commit cec7f1774605a5ef47c134af62afe7c75c30b0ee ]

    The virtio_gpu_init() will free vgdev and vgdev->vbufs on failure.
    But such failure will be caught by virtio_gpu_probe() and then
    virtio_gpu_release() will be called to do some cleanup which
    will free vgdev and vgdev->vbufs again. So let's set dev->dev_private
    to NULL to avoid double free.

    Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/20210517084913.403-2-xieyongji@bytedance.com
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/virtio/virtgpu_kms.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c
    index aa532ad31a23..f3379059f324 100644
    --- a/drivers/gpu/drm/virtio/virtgpu_kms.c
    +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c
    @@ -234,6 +234,7 @@ int virtio_gpu_init(struct drm_device *dev)
    err_vbufs:
    vgdev->vdev->config->del_vqs(vgdev->vdev);
    err_vqs:
    + dev->dev_private = NULL;
    kfree(vgdev);
    return ret;
    }
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-06 13:40    [W:4.041 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site