lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.12 001/160] drm/etnaviv: fix NULL check before some freeing functions is not needed
    Date
    From: Tian Tao <tiantao6@hisilicon.com>

    [ Upstream commit 7d614ab2f20503ed8766363d41f8607337571adf ]

    fixed the below warning:
    drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:84:2-8: WARNING: NULL check
    before some freeing functions is not needed.

    Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
    Acked-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
    index b390dd4d60b7..d741b1d735f7 100644
    --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
    +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
    @@ -80,8 +80,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj)
    /* Don't drop the pages for imported dmabuf, as they are not
    * ours, just free the array we allocated:
    */
    - if (etnaviv_obj->pages)
    - kvfree(etnaviv_obj->pages);
    + kvfree(etnaviv_obj->pages);

    drm_prime_gem_destroy(&etnaviv_obj->base, etnaviv_obj->sgt);
    }
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-06 13:40    [W:4.392 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site