lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] bus: Make remove callback return void
    On Tuesday 06 July 2021 11:50:37 Uwe Kleine-König wrote:
    > The driver core ignores the return value of this callback because there
    > is only little it can do when a device disappears.
    >
    > This is the final bit of a long lasting cleanup quest where several
    > buses were converted to also return void from their remove callback.
    > Additionally some resource leaks were fixed that were caused by drivers
    > returning an error code in the expectation that the driver won't go
    > away.
    >
    > With struct bus_type::remove returning void it's prevented that newly
    > implemented buses return an ignored error code and so don't anticipate
    > wrong expectations for driver authors.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    Acked-by: Pali Rohár <pali@kernel.org>

    > ---
    > Hello,
    >
    > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove
    > return void" that is not yet applied, see
    > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutronix.de.
    >
    > I tested it using allmodconfig on amd64 and arm, but I wouldn't be
    > surprised if I still missed to convert a driver. So it would be great to
    > get this into next early after the merge window closes.
    >
    > I send this mail to all people that get_maintainer.pl emits for this
    > patch. I wonder how many recipents will refuse this mail because of the
    > long Cc: list :-)
    >
    > Best regards
    > Uwe

    \
     
     \ /
      Last update: 2021-07-06 12:28    [W:3.956 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site