Messages in this thread | | | Subject | Re: [PATCH 1/3] asus-wmi: Add panel overdrive functionality | From | Hans de Goede <> | Date | Tue, 6 Jul 2021 12:08:34 +0200 |
| |
Hi,
One more remark inline:
On 7/5/21 12:21 AM, Luke D. Jones wrote: > Some ASUS ROG laptops have the ability to drive the display panel > a a higher rate to eliminate or reduce ghosting. > > Signed-off-by: Luke D. Jones <luke@ljones.dev> > --- > drivers/platform/x86/asus-wmi.c | 92 ++++++++++++++++++++++ > include/linux/platform_data/x86/asus-wmi.h | 1 + > 2 files changed, 93 insertions(+) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index ebaeb7bb80f5..2468076d6cd8 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c
<snip>
> +static ssize_t panel_od_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct asus_wmi *asus = dev_get_drvdata(dev); > + u8 mode = asus->panel_overdrive; > + > + return scnprintf(buf, PAGE_SIZE, "%d\n", mode);
As Barnabás pointed out in his review of patch 2/3, please use sysfs_emit here.
Regards,
Hans
| |