lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: Avoid accessing an already freed kobject in delete_partition
On Tue, Jul 06, 2021 at 06:31:11AM +0530, Rajat Asthana wrote:
>
>
> On 03/07/21 10:56 am, Christoph Hellwig wrote:
> > This should be fixed properly by:
> >
> > "block: check disk exist before trying to add partition"
>
> Hi Christoph, thanks a lot for suggesting this fix. I have been
> working on implementing this and have tried the following:
> - I checked if the the kobject of device structure embedded in
> gendisk structure is not NULL, to add the partition.
> This didn't work.
>
> - Then I checked the if kobject of the block_device struct (part0)
> embedded in the gendisk struct is not NULL, to add the partition.
> This also didn't work.
>
> - Then I checked the i_state of the bd_inode field of block_device
> struct embedded in the gendisk struct. I checked if the I_FREEING or
> I_WILL_FREE fields are not set. The reason behind doing this was
> to confirm that we only create partition on the disks which are not
> being freed.
>
> Am I going in the right direction? Can you point me to the correct
> direction if I am not?

No. There should be no need to check anything, but the code needs
to ensure that the block device is alive. I think the above mentioned
patch (now in Jens' tree) does that, so please try it.

\
 
 \ /
  Last update: 2021-07-06 07:13    [W:0.078 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site