On Tue, 6 Jul 2021 14:41:27 +0800 Guangbin Huang wrote:> + return devlink_info_version_running_put(req, "fw-version", version_str);Please use one of the existing names instead of "fw-version",e.g. DEVLINK_INFO_VERSION_GENERIC_FW.