lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH AUTOSEL 5.13 113/189] drm/amdgpu/gfx9: fix the doorbell missing when in CGPG issue.
    From
    Date
    Am 2021-07-06 um 5:44 p.m. schrieb Alex Deucher:
    > On Tue, Jul 6, 2021 at 7:16 AM Sasha Levin <sashal@kernel.org> wrote:
    >> From: Yifan Zhang <yifan1.zhang@amd.com>
    >>
    >> [ Upstream commit 631003101c516ea29a74aee59666708857b9a805 ]
    >>
    >> If GC has entered CGPG, ringing doorbell > first page doesn't wakeup GC.
    >> Enlarge CP_MEC_DOORBELL_RANGE_UPPER to workaround this issue.
    >>
    >> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
    >> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
    >> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    >> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    >> Signed-off-by: Sasha Levin <sashal@kernel.org>
    > This should be dropped. It was already reverted.

    Patch 146 of this series is the corresponding revert.

    Regards,
      Felix


    >
    > Alex
    >
    >
    >> ---
    >> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 6 +++++-
    >> 1 file changed, 5 insertions(+), 1 deletion(-)
    >>
    >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
    >> index 516467e962b7..c09225d065c2 100644
    >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
    >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
    >> @@ -3673,8 +3673,12 @@ static int gfx_v9_0_kiq_init_register(struct amdgpu_ring *ring)
    >> if (ring->use_doorbell) {
    >> WREG32_SOC15(GC, 0, mmCP_MEC_DOORBELL_RANGE_LOWER,
    >> (adev->doorbell_index.kiq * 2) << 2);
    >> + /* If GC has entered CGPG, ringing doorbell > first page doesn't
    >> + * wakeup GC. Enlarge CP_MEC_DOORBELL_RANGE_UPPER to workaround
    >> + * this issue.
    >> + */
    >> WREG32_SOC15(GC, 0, mmCP_MEC_DOORBELL_RANGE_UPPER,
    >> - (adev->doorbell_index.userqueue_end * 2) << 2);
    >> + (adev->doorbell.size - 4));
    >> }
    >>
    >> WREG32_SOC15_RLC(GC, 0, mmCP_HQD_PQ_DOORBELL_CONTROL,
    >> --
    >> 2.30.2
    >>
    >> _______________________________________________
    >> amd-gfx mailing list
    >> amd-gfx@lists.freedesktop.org
    >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

    \
     
     \ /
      Last update: 2021-07-07 01:10    [W:4.664 / U:0.760 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site