Messages in this thread | | | From | Cornelia Huck <> | Subject | Re: [PATCH v2 4/4] bus: Make remove callback return void | Date | Tue, 06 Jul 2021 18:09:17 +0200 |
| |
On Tue, Jul 06 2021, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> (For ARM, Amba and related parts) > Acked-by: Mark Brown <broonie@kernel.org> > Acked-by: Chen-Yu Tsai <wens@csie.org> (for drivers/bus/sunxi-rsb.c) > Acked-by: Pali Rohár <pali@kernel.org> > Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org> (for drivers/media) > Acked-by: Hans de Goede <hdegoede@redhat.com> (For drivers/platform) > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > Acked-By: Vinod Koul <vkoul@kernel.org> > Acked-by: Juergen Gross <jgross@suse.com> (For Xen) > Acked-by: Lee Jones <lee.jones@linaro.org> (For drivers/mfd) > Acked-by: Johannes Thumshirn <jth@kernel.org> (For drivers/mcb) > Acked-by: Johan Hovold <johan@kernel.org> > Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> (For drivers/slimbus) > Acked-by: Kirti Wankhede <kwankhede@nvidia.com> (For drivers/vfio) > Acked-by: Maximilian Luz <luzmaximilian@gmail.com> > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> (For ulpi and typec) > Acked-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com> (For ipack) > Reviewed-by: Tom Rix <trix@redhat.com> (For fpga) > Acked-by: Geoff Levand <geoff@infradead.org> (For ps3) > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > > drivers/s390/cio/ccwgroup.c | 4 +--- > drivers/s390/cio/css.c | 4 +--- > drivers/s390/cio/device.c | 4 +--- > drivers/s390/cio/scm.c | 4 +--- > drivers/s390/crypto/ap_bus.c | 4 +--- > drivers/vfio/mdev/mdev_driver.c | 4 +---
For drivers/s390 and drivers/vfio:
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
| |