Messages in this thread | | | Subject | Re: [RFC PATCH v2 08/69] KVM: TDX: add trace point before/after TDX SEAMCALLs | From | Paolo Bonzini <> | Date | Tue, 6 Jul 2021 15:23:55 +0200 |
| |
On 03/07/21 00:04, isaku.yamahata@intel.com wrote: > + trace_kvm_tdx_seamcall_enter(smp_processor_id(), op, > + rcx, rdx, r8, r9, r10); > + err = __seamcall(op, rcx, rdx, r8, r9, r10, ex); > + if (ex) > + trace_kvm_tdx_seamcall_exit(smp_processor_id(), op, err, ex->rcx, > + ex->rdx, ex->r8, ex->r9, ex->r10, > + ex->r11); > + else > + trace_kvm_tdx_seamcall_exit(smp_processor_id(), op, err, > + 0, 0, 0, 0, 0, 0);
Would it make sense to do the zeroing of ex directly in __seamcall in case there is an error?
Otherwise looks good.
Paolo
| |