Messages in this thread Patch in this message | | | From | gushengxian <> | Subject | [PATCH v2] tools: bpftool: close va_list 'ap' by va_end() | Date | Mon, 5 Jul 2021 18:11:50 -0700 |
| |
From: gushengxian <gushengxian@yulong.com>
va_list 'ap' was opened but not closed by va_end(). It should be closed by va_end() before return.
According to suggestion of Daniel Borkmann <daniel@iogearbox.net>. Signed-off-by: gushengxian <gushengxian@yulong.com> --- tools/bpf/bpftool/jit_disasm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c index e7e7eee9f172..24734f2249d6 100644 --- a/tools/bpf/bpftool/jit_disasm.c +++ b/tools/bpf/bpftool/jit_disasm.c @@ -43,11 +43,13 @@ static int fprintf_json(void *out, const char *fmt, ...) { va_list ap; char *s; + int err; va_start(ap, fmt); - if (vasprintf(&s, fmt, ap) < 0) - return -1; + err = vasprintf(&s, fmt, ap); va_end(ap); + if (err < 0) + return -1; if (!oper_count) { int i; -- 2.25.1
| |