Messages in this thread | | | Date | Mon, 5 Jul 2021 21:15:26 +0100 | From | Matthew Wilcox <> | Subject | Re: [RFC PATCH 2/2] erofs: directly traverse pages in z_erofs_readahead() |
| |
On Tue, Jul 06, 2021 at 02:32:53AM +0800, Gao Xiang wrote: > In that way, pages can be accessed directly with xarray.
I didn't mean "open code readahead_page()". I meant "Wouldn't it be great if z_erofs_do_read_page() used readahead_expand() in order to allocate the extra pages in the extents that cover the start and end of the requested chunk". That way the pages would already be in the page cache for subsequent reads.
| |