lkml.org 
[lkml]   [2021]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v12] i2c: virtio: add a virtio i2c frontend driver
From
Date
On 2021/7/5 14:30, Viresh Kumar wrote:

>>
>> This is still not enough to convince me.  So I won't change them for now
>> until I see it
>>
>> is the consensus of the majority.
> Do you see reqs[i] to ever be NULL here ? If not, then if (req) is like if
> (true).
>
> Why would you want to have something like that ?

No. Currently, virtio_i2c_complete_reqs is only called by
virtio_i2c_xfer, thus we don't

have reqs[i] to be NULL. But I think "virtio_i2c_complete_reqs" as an
independent function

should consider this from a callee perspective.

Anyway, if you really think it should be changed, it can be fixed
incrementally as Wolfram said.


\
 
 \ /
  Last update: 2021-07-05 09:14    [W:1.204 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site