Messages in this thread | | | From | Uladzislau Rezki <> | Date | Mon, 5 Jul 2021 17:43:24 +0200 | Subject | Re: [PATCH] mm/vmalloc: Use batched page requests in bulk-allocator |
| |
> On Mon, Jul 05, 2021 at 04:55:47PM +0200, Uladzislau Rezki (Sony) wrote: > > + if (gfpflags_allow_blocking(gfp)) > > + cond_resched(); > > How does one call vmalloc() with gfp flags that _don't_ allow blocking? > They have to allow a GFP_KERNEL allocation of the page tables. > So I think this should be an unconditional cond_resched(). Historically it is there. I decided to align with below code. But i agree vmalloc is sleepable anyway, so blocking is supposed.
OK, i will respin and send out two patches.
-- Vlad Rezki
| |