Messages in this thread | | | Subject | Re: [PATCH] EDAC, altera: skip defining unused structures for specific configs | From | Krzysztof Kozlowski <> | Date | Mon, 5 Jul 2021 17:13:21 +0200 |
| |
On 01/06/2021 11:27, Krzysztof Kozlowski wrote: > The Altera EDAC driver has several features conditionally built > depending on Kconfig options. The edac_device_prv_data structures are > conditionally used in of_device_id tables. They reference other > functions and structures which can be defined as __maybe_unused. This > silences build warnings like: > > drivers/edac/altera_edac.c:643:37: warning: > ‘altr_edac_device_inject_fops’ defined but not used [-Wunused-const-variable=] > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > drivers/edac/altera_edac.c | 44 ++++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 18 deletions(-)
Hi Altera and EDAC maintainers,
Any comments on this patch?
Best regards, Krzysztof
| |