Messages in this thread | | | From | Marco Elver <> | Date | Mon, 5 Jul 2021 13:18:06 +0200 | Subject | Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG |
| |
On Mon, 5 Jul 2021 at 13:12, Andrey Konovalov <andreyknvl@gmail.com> wrote: [...] > > + /* > > + * Explicitly initialize the memory with the precise object size to > > + * avoid overwriting the SLAB redzone. This disables initialization in > > + * the arch code and may thus lead to performance penalty. The penalty > > + * is accepted since SLAB redzones aren't enabled in production builds. > > + */ > > + if (__slub_debug_enabled() && > > What happened to slub_debug_enabled_unlikely()? Was it renamed? Why? I > didn't receive patch #1 of v6 (nor of v5).
Somebody had the same idea with the helper: https://lkml.kernel.org/r/YOKsC75kJfCZwySD@elver.google.com and Matthew didn't like the _unlikely() prefix.
Which meant we should just move the existing helper introduced in the merge window.
Patch 1/2: https://lkml.kernel.org/r/20210705103229.8505-2-yee.lee@mediatek.com
Thanks, -- Marco
| |