lkml.org 
[lkml]   [2021]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.12 51/80] mmc: sdhci-of-aspeed: Turn down a phase correction warning
    Date
    From: Andrew Jeffery <andrew@aj.id.au>

    [ Upstream commit a7ab186f60785850b5af1be183867000485ad491 ]

    The card timing and the bus frequency are not changed atomically with
    respect to calls to the set_clock() callback in the driver. The result
    is the driver sees a transient state where there's a mismatch between
    the two and thus the inputs to the phase correction calculation
    formula are garbage.

    Switch from dev_warn() to dev_dbg() to avoid noise in the normal case,
    though the change does make bad configurations less likely to be
    noticed.

    Reported-by: Joel Stanley <joel@jms.id.au>
    Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
    Reviewed-by: Joel Stanley <joel@jms.id.au>
    Link: https://lore.kernel.org/r/20210607013020.85885-1-andrew@aj.id.au
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/sdhci-of-aspeed.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c
    index 7d8692e90996..b6ac2af199b8 100644
    --- a/drivers/mmc/host/sdhci-of-aspeed.c
    +++ b/drivers/mmc/host/sdhci-of-aspeed.c
    @@ -150,7 +150,7 @@ static int aspeed_sdhci_phase_to_tap(struct device *dev, unsigned long rate_hz,

    tap = div_u64(phase_period_ps, prop_delay_ps);
    if (tap > ASPEED_SDHCI_NR_TAPS) {
    - dev_warn(dev,
    + dev_dbg(dev,
    "Requested out of range phase tap %d for %d degrees of phase compensation at %luHz, clamping to tap %d\n",
    tap, phase_deg, rate_hz, ASPEED_SDHCI_NR_TAPS);
    tap = ASPEED_SDHCI_NR_TAPS;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-05 01:10    [W:4.432 / U:1.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site