lkml.org 
[lkml]   [2021]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.12 04/80] media: i2c: imx334: fix the pm runtime get logic
    Date
    From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

    [ Upstream commit 62c90446868b439929cb04395f04a709a64ae04b ]

    The PM runtime get logic is currently broken, as it checks if
    ret is zero instead of checking if it is an error code,
    as reported by Dan Carpenter.

    While here, use the pm_runtime_resume_and_get() as added by:
    commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
    added pm_runtime_resume_and_get() in order to automatically handle
    dev->power.usage_count decrement on errors. As a bonus, such function
    always return zero on success.

    It should also be noticed that a fail of pm_runtime_get_sync() would
    potentially result in a spurious runtime_suspend(), instead of
    using pm_runtime_put_noidle().

    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
    Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/imx334.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
    index ad530f0d338a..02d22907c75c 100644
    --- a/drivers/media/i2c/imx334.c
    +++ b/drivers/media/i2c/imx334.c
    @@ -717,9 +717,9 @@ static int imx334_set_stream(struct v4l2_subdev *sd, int enable)
    }

    if (enable) {
    - ret = pm_runtime_get_sync(imx334->dev);
    - if (ret)
    - goto error_power_off;
    + ret = pm_runtime_resume_and_get(imx334->dev);
    + if (ret < 0)
    + goto error_unlock;

    ret = imx334_start_streaming(imx334);
    if (ret)
    @@ -737,6 +737,7 @@ static int imx334_set_stream(struct v4l2_subdev *sd, int enable)

    error_power_off:
    pm_runtime_put(imx334->dev);
    +error_unlock:
    mutex_unlock(&imx334->mutex);

    return ret;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-05 01:09    [W:4.641 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site