Messages in this thread | | | From | Linus Torvalds <> | Date | Sun, 4 Jul 2021 14:28:03 -0700 | Subject | Re: [PATCH 01/17] kallsyms: support big kernel symbols (2-byte lengths) |
| |
On Sun, Jul 4, 2021 at 2:15 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > No particular reason. It makes sense to use LE -- I will change it.
Matthew's suggestion is denser, which is nice.
At that point, it would be neither BE nor LE. But the "LE-like" version would be
len = data[0]; if (len & 128) len += data[1] << 7;
which ends up having a tiny bit more range (it goes to 11^H32895).
Of course, if the range is expected to be just 0-300, I guess that matters not one whit.
Linus
| |