lkml.org 
[lkml]   [2021]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 3/3] net: hns3: add support for link diagnosis info in debugfs
> > > Hi Jakub, I have a question to consult you.
> > > Some fault information in our patch are not existed in current ethtool extended
> > > link states, for examples:
> > > "Serdes reference clock lost"
> > > "Serdes analog loss of signal"
> > > "SFP tx is disabled"
> > > "PHY power down"
> >
> > Why would the PHY be powered down if user requested port to be up?
> >
> In the case of other user may use MDIO tool to write PHY register directly to make
> PHY power down, if link state can display this information, I think it is helpful.

If the user directly writes to PHY registers, they should expect bad
things to happen. They can do a lot more than power the PHY down. They
could configure it into loopback mode, turn off autoneg and force a
mode which is compatible with the peer, etc.

I don't think you need to tell the user they have pointed a foot gun
at their feet and pulled the trigger.

Andrew

\
 
 \ /
  Last update: 2021-07-04 21:59    [W:0.083 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site