Messages in this thread | | | Date | Sat, 31 Jul 2021 09:18:48 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 04/12] x86/sev: Do not hardcode GHCB protocol version |
| |
Hi Tom,
On Wed, Jul 21, 2021 at 04:17:38PM -0500, Tom Lendacky wrote: > On 7/21/21 9:20 AM, Joerg Roedel wrote: > > /* Fill in protocol and format specifiers */ > > - ghcb->protocol_version = GHCB_PROTOCOL_MAX; > > + ghcb->protocol_version = sev_get_ghcb_proto_ver(); > > So this probably needs better clarification in the spec, but the GHCB > version field is for the GHCB structure layout. So if you don't plan to > use the XSS field that was added for version 2 of the layout, then you > should report the GHCB structure version as 1.
Yeah, this makes sense, exept for the struct field-name ;) But anyway, I keep the version field at 1 for now.
Regards,
Joerg
| |