lkml.org 
[lkml]   [2021]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7
From
Date
30.07.2021 20:37, Dmitry Osipenko пишет:
> 17.07.2021 21:21, Dmitry Osipenko пишет:
> ...
>> power: supply: smb347-charger: Make smb347_set_writable() IRQ-safe
>> power: supply: smb347-charger: Utilize generic regmap caching
>> power: supply: smb347-charger: Implement USB VBUS regulator
>
> I noticed that charging doesn't work properly now, will fix it in v6.
>

For the record, it wasn't enough to enable the regmap caching, we also
need to fill up the cache on init by specifying the num_reg_defaults_raw
parameter.

This uncovered another problem where the pin control "enable" bit was
unsettling because the default regmap values were initialized to zeros
and driver doesn't set the enable bit at all.

\
 
 \ /
  Last update: 2021-07-30 20:35    [W:0.095 / U:2.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site