Messages in this thread | | | Date | Fri, 30 Jul 2021 09:59:36 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] net: phy: micrel: Fix detection of ksz87xx switch |
| |
Please extend the CC list to the maintainers, and people who worked on this driver in the past, especially Marek.
On Fri, 30 Jul 2021 20:51:20 +1000 Steve Bennett wrote: > The previous logic was wrong such that the ksz87xx > switch was not identified correctly.
Any more details of what is happening? Which extact device do you see this problem on?
I presume ksz87xx devices used to work and gotten broken - would you mind clarifying and adding a Fixes tag to help backporting to the correct stable branches?
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 4d53886f7d51..a4acec02c8cb 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -401,11 +401,11 @@ static int ksz8041_config_aneg(struct phy_device *phydev) > } > > static int ksz8051_ksz8795_match_phy_device(struct phy_device *phydev, > - const u32 ksz_phy_id) > + const u32 ksz_8051)
bool and use true/false in the callers?
| |