Messages in this thread | | | Subject | Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98357a: fix drv_name | From | Cezary Rojewski <> | Date | Fri, 30 Jul 2021 15:50:48 +0200 |
| |
On 2021-07-30 1:59 PM, Lukasz Majczak wrote: > platform_id for kbl_da7219_max98357a was shrunk for kbl_da7219_mx98357a, > but the drv_name was changed for kbl_da7219_max98373. Tested on a > Pixelbook (Atlas).
Reasoning behind Pierre's initial commit is valid and I believe kbl_da7219_max98373 name change was simply unintended. To make the situation clearer, please be more elaborate in commit's message.
> Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters") > Cc: <stable@vger.kernel.org> # 5.4+ > Reported-by: Cezary Rojewski <cezary.rojewski@intel.com>
Please reword to: Suggested-by. I certainly wasn't the one who found the problem first, but I did provide the initial fix.
I don't see any problem is the code, so besides formalities:
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Thanks, Czarek
| |