lkml.org 
[lkml]   [2021]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bcm63xx_enet: simplify the code in bcm_enet_open()
On Thu, 29 Jul 2021 14:23:28 -0700 Florian Fainelli wrote:
> On 7/29/21 12:06 AM, Tang Bin wrote:
> > In the function bcm_enet_open(), 'ret = -ENOMEM' can be moved
> > outside the judgement statement, so redundant assignments can
> > be removed to simplify the code.
> >
> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>

I wouldn't, the existing code is more robust IMO, but your call :)

Does not apply to net-next, please rebase.

\
 
 \ /
  Last update: 2021-07-30 15:30    [W:0.962 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site