Messages in this thread | | | Subject | Re: [PATCHv1 1/3] arm64: dts: amlogic: add missing ethernet reset ID | From | Philipp Zabel <> | Date | Fri, 30 Jul 2021 11:42:19 +0200 |
| |
Hi Anand,
On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote: > Add reset external reset of the ethernet mac controller, > used new reset id for reset controller as it conflict > with the core reset id. > > Fixes: f3362f0c1817 ("arm64: dts: amlogic: add missing ethernet reset ID") > > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++ > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++ > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++ > 3 files changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index 3f5254eeb47b..da3bf9f7c1c6 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -280,6 +280,8 @@ ethmac: ethernet@ff3f0000 { > "timing-adjustment"; > rx-fifo-depth = <4096>; > tx-fifo-depth = <2048>; > + resets = <&reset RESET_ETHERNET>; > + reset-names = "ethreset";
This is missing binding documentation. Also, is this reset name taken from the documentation? Otherwise, it would probably be better to call it "phy" for a PHY reset.
regards Philipp
| |