Messages in this thread | | | Date | Sat, 31 Jul 2021 09:17:18 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH v3 RESEND] x86/tools: fix objdump version check again |
| |
On Fri, 30 Jul 2021 17:01:46 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> Skip (omit) any version string info that is parenthesized. > > Warning: objdump version 15) is older than 2.19 > Warning: Skipping posttest. > > where 'objdump -v' says: > GNU objdump (GNU Binutils; SUSE Linux Enterprise 15) 2.35.1.20201123-7.18
Looks good to me.
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
> > Fixes: 8bee738bb1979 ("x86: Fix objdump version check in chkobjdump.awk for different formats.") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Masami Hiramatsu <mhiramat@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: H. Peter Anvin <hpa@zytor.com> > Cc: x86@kernel.org > Cc: Borislav Petkov <bp@alien8.de> > --- > v3: rebase & resend > correct Ingo's email address (not @elte.hu) > add x86@kernel.org email address > add BP's email address > > arch/x86/tools/chkobjdump.awk | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210715.orig/arch/x86/tools/chkobjdump.awk > +++ linux-next-20210715/arch/x86/tools/chkobjdump.awk > @@ -10,6 +10,7 @@ BEGIN { > > /^GNU objdump/ { > verstr = "" > + gsub(/\(.*\)/, ""); > for (i = 3; i <= NF; i++) > if (match($(i), "^[0-9]")) { > verstr = $(i);
-- Masami Hiramatsu <mhiramat@kernel.org>
| |