Messages in this thread | | | Subject | Re: [GIT PULL] thermal for v5.14-rc1 | From | Dmitry Osipenko <> | Date | Sat, 3 Jul 2021 22:56:25 +0300 |
| |
03.07.2021 22:34, Linus Torvalds пишет: > On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: >> >> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git >> tags/thermal-v5.14-rc1 > > This does not build for me. And I suspect it never built in linux-next either. > > I get > > ERROR: modpost: "tegra_fuse_readl" > [drivers/thermal/tegra/tegra30-tsensor.ko] undefined! > ERROR: modpost: "tegra_fuse_readl" > [drivers/thermal/tegra/tegra-soctherm.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1 > make[1]: *** Deleting file 'modules-only.symvers' > make: *** [Makefile:1762: modules] Error 2 > > and I think it's due to that commit 1f9c5936b10c > ("thermal/drivers/tegra: Correct compile-testing of drivers") which > quite sensibly tries to extend build coverage for the tegra thermal > drivers, but that build coverage doesn't actually *work* outside the > tegra world. > > That commit says "All Tegra thermal drivers support compile-testing", > but clearly they stumble at the last hurdle. > > I made the decision to just unpull this, not because I couldn't fix > it, but because if it was this untested, I don't want to worry about > all the *other* code in there too.
It was tested in linux-next for about two weeks and it was a known problem already [1], sorry again. The compile-testing depends on the patch [2] that should come with the ARM32 PR. The linux-next was okay because [2] got first into -next and I forgot about it. It will be fine to defer these Tegra patches till the next release if this is the easiest solution.
[1] https://lore.kernel.org/linux-devicetree/20210616190417.32214-7-digetx@gmail.com/T/#m354e679e93c4f84e26d5e630423e47317d0c2edc
[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=30b44e81772a5caa983000057ce1cd9cb4531647
| |