Messages in this thread | | | Subject | Re: [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup | From | Shuah Khan <> | Date | Thu, 29 Jul 2021 12:42:44 -0600 |
| |
On 7/29/21 11:16 AM, Bart Van Assche wrote: > On 7/29/21 9:55 AM, Shuah Khan wrote: >> On 7/29/21 10:52 AM, Bart Van Assche wrote: >>> On 7/28/21 10:55 PM, Greg KH wrote: >>>> On Wed, Jul 28, 2021 at 09:41:24PM -0700, Bart Van Assche wrote: >>>>> Reviewed-by: Brendan Higgins <brendanhiggins@google.com> >>>>> Cc: David Gow <davidgow@google.com> >>>>> Cc: Shuah Khan <skhan@linuxfoundation.org> >>>>> Cc: kunit-dev@googlegroups.com >>>>> Cc: linux-kselftest@vger.kernel.org >>>>> Cc: Bodo Stroesser <bostroesser@gmail.com> >>>>> Cc: Martin K. Petersen <martin.petersen@oracle.com> >>>>> Cc: Yanko Kaneti <yaneti@declera.com> >>>>> Signed-off-by: Bart Van Assche <bvanassche@acm.org> >>>>> --- >>>> >>>> I know I do not take patches without any changelog text. Maybe other >>>> maintainers are more lax :( >>> >>> Almost every patch from me has an elaborate changelog. For this patch I chose not to add a changelog since I think that the subject is self-explanatory? >> >> I don't take patches without change logs either. I can't say the subject >> tells me what you are doing. >> >> Please add a change log. > > I will add a changelog. But please note that this patch has been sent to Christoph as configfs maintainer. >
Sure. This is a kunit patch - hence Kunit maintainers can comment on it. Besides the comment is about missing change log which is rather basic kernel dev 101.
Please take a look at Documentation/process/submitting-patches.rst for information on commit logs.
thanks, -- Shuah
| |