lkml.org 
[lkml]   [2021]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 0/5] DT schema changes for HiKey970 PCIe hardware to work
    On Thu, Jul 29, 2021 at 5:56 AM Mauro Carvalho Chehab
    <mchehab+huawei@kernel.org> wrote:
    >
    > Hi Rob,
    >
    > After our discussions, I'm opting to submit first the DT bindings for the
    > Kirin 970 PCIe support.
    >
    > Patch 1 is there just because patch 2 needs. You already acked on it.
    >
    > Patch 5 is also there just as an example of the entire stuff added to
    > the DTS file.
    >
    > The core of this series are patches 2 to 4. They contain the conversion
    > of the kirin-pcie.txt file to the DT schema, and adds the needed
    > bindings.
    >
    > Currently, it generates some warnings:
    >
    > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: pcie@4,0:compatible: None of ['pciclass,0604'] are valid under the given schema
    > From schema: Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml

    This should be fixed now in dtschema master.

    > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@4,0: reset-gpios: [[4294967295, 1, 0]] is too short

    Your proposed change to pci-bus.yaml is wrong. It's requiring 4
    entries. You need 'minItems: 1'.

    Rob

    \
     
     \ /
      Last update: 2021-07-29 19:21    [W:4.045 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site