Messages in this thread | | | From | Paolo Bonzini <> | Subject | Re: [PATCH] KVM: SVM: delay svm_vcpu_init_msrpm after svm->vmcb is initialized | Date | Thu, 29 Jul 2021 18:30:49 +0200 |
| |
On 28/07/21 22:18, Vineeth Pillai wrote: > > On 7/27/2021 11:23 AM, Vitaly Kuznetsov wrote: >> Paolo Bonzini <pbonzini@redhat.com> writes: >> >>> Right now, svm_hv_vmcb_dirty_nested_enlightenments has an incorrect >>> dereference of vmcb->control.reserved_sw before the vmcb is checked >>> for being non-NULL. The compiler is usually sinking the dereference >>> after the check; instead of doing this ourselves in the source, >>> ensure that svm_hv_vmcb_dirty_nested_enlightenments is only called >>> with a non-NULL VMCB. >>> >>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >>> Cc: Vineeth Pillai <viremana@linux.microsoft.com> >>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> >>> [Untested for now due to issues with my AMD machine. - Paolo] > Finally got hold of an AMD machine and tested nested virt: windows on > linux on > windows with the patches applied. Did basic boot and minimal verification. > > Tested-by: Vineeth Pillai <viremana@linux.microsoft.com>
Thanks! In the meanwhile I had fixed my machine too. :)
Paolo
| |