lkml.org 
[lkml]   [2021]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 17/21] cifs: fix the out of range assignment to bit fields in parse_server_interfaces
    Date
    From: Hyunchul Lee <hyc.lee@gmail.com>

    [ Upstream commit c9c9c6815f9004ee1ec87401ed0796853bd70f1b ]

    Because the out of range assignment to bit fields
    are compiler-dependant, the fields could have wrong
    value.

    Signed-off-by: Hyunchul Lee <hyc.lee@gmail.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/cifs/smb2ops.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
    index bf6b4f71dc58..defee1d208d2 100644
    --- a/fs/cifs/smb2ops.c
    +++ b/fs/cifs/smb2ops.c
    @@ -498,8 +498,8 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
    p = buf;
    while (bytes_left >= sizeof(*p)) {
    info->speed = le64_to_cpu(p->LinkSpeed);
    - info->rdma_capable = le32_to_cpu(p->Capability & RDMA_CAPABLE);
    - info->rss_capable = le32_to_cpu(p->Capability & RSS_CAPABLE);
    + info->rdma_capable = le32_to_cpu(p->Capability & RDMA_CAPABLE) ? 1 : 0;
    + info->rss_capable = le32_to_cpu(p->Capability & RSS_CAPABLE) ? 1 : 0;

    cifs_dbg(FYI, "%s: adding iface %zu\n", __func__, *iface_count);
    cifs_dbg(FYI, "%s: speed %zu bps\n", __func__, info->speed);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-29 15:58    [W:3.249 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site