| From | Vlastimil Babka <> | Subject | [PATCH v3 01/35] mm, slub: don't call flush_all() from slab_debug_trace_open() | Date | Thu, 29 Jul 2021 15:20:58 +0200 |
| |
slab_debug_trace_open() can only be called on caches with SLAB_STORE_USER flag and as with all slub debugging flags, such caches avoid cpu or percpu partial slabs altogether, so there's nothing to flush.
Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Acked-by: Christoph Lameter <cl@linux.com> --- mm/slub.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c index 090fa14628f9..422a61d7bf5f 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5820,9 +5820,6 @@ static int slab_debug_trace_open(struct inode *inode, struct file *filep) if (!alloc_loc_track(t, PAGE_SIZE / sizeof(struct location), GFP_KERNEL)) return -ENOMEM; - /* Push back cpu slabs */ - flush_all(s); - for_each_kmem_cache_node(s, node, n) { unsigned long flags; struct page *page; -- 2.32.0
|