Messages in this thread Patch in this message | | | From | Christophe JAILLET <> | Subject | [PATCH] can: flexcan: Fix an uninitialized variable issue | Date | Thu, 29 Jul 2021 13:27:42 +0200 |
| |
If both 'clk_ipg' and 'clk_per' are NULL, we return an un-init value. So set 'err' to 0, to return success in such a case.
Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Another way to fix it is to remove the NULL checks for 'clk_ipg' and 'clk_per' that been added in commit d9cead75b1c6.
They look useless to me because 'clk_prepare_enable()' returns 0 if it is passed a NULL pointer. Having these explicit tests is maybe informational (i.e. these pointers can really be NULL) or have been added to silent a compiler or a static checker.
So, in case, I've left the tests and just fixed the un-init 'err' variable issue. --- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index 54ffb796a320..7734229aa078 100644 --- a/drivers/net/can/flexcan.c +++ b/drivers/net/can/flexcan.c @@ -649,7 +649,7 @@ static inline void flexcan_error_irq_disable(const struct flexcan_priv *priv) static int flexcan_clks_enable(const struct flexcan_priv *priv) { - int err; + int err = 0; if (priv->clk_ipg) { err = clk_prepare_enable(priv->clk_ipg); -- 2.30.2
| |