Messages in this thread | | | Date | Wed, 28 Jul 2021 07:44:31 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: rtl8723bs: core: Fix incorrect type in assignment |
| |
On Wed, Jul 28, 2021 at 02:42:23AM +0200, Fabio M. De Francesco wrote: > Fix sparse warning: incorrect type in assignment (different base types). > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> > --- > drivers/staging/rtl8723bs/core/rtw_security.c | 31 +++++++++++-------- > 1 file changed, 18 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c > index a99f439328f1..527f710c7658 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_security.c > +++ b/drivers/staging/rtl8723bs/core/rtw_security.c > @@ -35,8 +35,10 @@ const char *security_type_str(u8 value) > */ > void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe) > { /* exclude ICV */ > - > - unsigned char crc[4]; > + union { > + __le32 f0; > + unsigned char f1[4]; > + } crc;
Odd indentation, are you sure this is right?
Please indent the fields by one more tab.
thanks,
greg k-h
| |