Messages in this thread | | | Subject | Re: [RFC 03/11] hte: Add tegra194 HTE kernel provider | From | Dipen Patel <> | Date | Wed, 28 Jul 2021 19:43:09 -0700 |
| |
Thanks for the suggestion, will change it in next RFC series.
On 7/8/21 4:33 PM, Michał Mirosław wrote: > On Fri, Jun 25, 2021 at 04:55:24PM -0700, Dipen Patel wrote: >> Tegra194 device has multiple HTE instances also known as GTE >> (Generic hardware Timestamping Engine) which can timestamp subset of >> SoC lines/signals. This provider driver focuses on IRQ and GPIO lines >> and exposes timestamping ability on those lines to the consumers >> through HTE subsystem. > [...] >> + ret = of_property_read_u32(dev->of_node, "slices", &slices); >> + if (ret != 0) { >> + dev_err(dev, "Could not read slices\n"); >> + return -EINVAL; >> + } >> + >> + hte_dev->sl = devm_kzalloc(dev, sizeof(struct hte_slices) * slices, >> + GFP_KERNEL); > Nit: There is devm_kcalloc() that will check for overflow in the > multiply in case @slices from DT is broken. > > Best Regards > Michał Mirosław
| |