Messages in this thread | | | Subject | Re: [f2fs-dev] [PATCH v4] f2fs: change fiemap way in printing compression chunk | From | Chao Yu <> | Date | Thu, 29 Jul 2021 08:37:26 +0800 |
| |
On 2021/7/28 0:41, Daeho Jeong wrote: > How about adding this? > > skip_fill: > > if (map.m_pblk == COMPRESS_ADDR) { > > if (start_blk & (cluster_size - 1)) { > > ret = -EFSCORRUPTED; > > goto out; > > } > > compr_cluster = true; > > count_in_cluster = 1; > > } else if (compr_appended) {
It seems we can add a separate patch to cover all cases that cluster metadata is going to be accessed rather than just fixing fiemap() case here?
>>> Signed-off-by: Daeho Jeong <daehojeong@google.com> >>> Tested-by: Eric Biggers <ebiggers@google.com>
Anyway, this patch looks good to me.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
| |