lkml.org 
[lkml]   [2021]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [f2fs-dev] [PATCH v4] f2fs: change fiemap way in printing compression chunk
From
Date
On 2021/7/28 0:41, Daeho Jeong wrote:
> How about adding this?
>
> skip_fill:
>
> if (map.m_pblk == COMPRESS_ADDR) {
>
> if (start_blk & (cluster_size - 1)) {
>
> ret = -EFSCORRUPTED;
>
> goto out;
>
> }
>
> compr_cluster = true;
>
> count_in_cluster = 1;
>
> } else if (compr_appended) {

It seems we can add a separate patch to cover all cases that cluster metadata is
going to be accessed rather than just fixing fiemap() case here?

>>> Signed-off-by: Daeho Jeong <daehojeong@google.com>
>>> Tested-by: Eric Biggers <ebiggers@google.com>

Anyway, this patch looks good to me.

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

\
 
 \ /
  Last update: 2021-07-29 02:38    [W:0.469 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site