Messages in this thread | | | Subject | Re: [PATCH] hwmon: (pmbus/ibm-cffps) Fix write bits for LED control | From | Guenter Roeck <> | Date | Wed, 28 Jul 2021 16:14:52 -0700 |
| |
On 7/28/21 3:41 PM, Brandon Wyman wrote: > From: "B. J. Wyman" <bjwyman@gmail.com> > > When doing a PMBus write for the LED control on the IBM Common Form > Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7 > be low and bit 6 be high in order to indicate that you are truly > attempting to do a write. > > Signed-off-by: B. J. Wyman <bjwyman@gmail.com>
Please be consistent and use "Brandon Wyman".
Guenter
> --- > drivers/hwmon/pmbus/ibm-cffps.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c > index 5668d8305b78..df712ce4b164 100644 > --- a/drivers/hwmon/pmbus/ibm-cffps.c > +++ b/drivers/hwmon/pmbus/ibm-cffps.c > @@ -50,9 +50,9 @@ > #define CFFPS_MFR_VAUX_FAULT BIT(6) > #define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7) > > -#define CFFPS_LED_BLINK BIT(0) > -#define CFFPS_LED_ON BIT(1) > -#define CFFPS_LED_OFF BIT(2) > +#define CFFPS_LED_BLINK (BIT(0) | BIT(6)) > +#define CFFPS_LED_ON (BIT(1) | BIT(6)) > +#define CFFPS_LED_OFF (BIT(2) | BIT(6)) > #define CFFPS_BLINK_RATE_MS 250 > > enum { >
| |