Messages in this thread | | | Subject | Re: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC pages | From | Dave Hansen <> | Date | Wed, 28 Jul 2021 15:19:46 -0700 |
| |
On 7/28/21 1:46 PM, Tony Luck wrote: > Export a function sgx_is_epc_page() that simply reports whether an > address is an EPC page for use elsewhere in the kernel.
It would be really nice to mention why this needs to be exported to modules. I assume it's the error injection driver or something that can be built as a module, but this export was a surprise when I saw it.
It's probably also worth noting that this is a sloooooooow implementation compared to the core VM code that does something analogous: pfn_to_page(). It's fine for error handling, but we should probably have a comment to this effect so that more liberal use doesn't creep in anywhere.
| |