lkml.org 
[lkml]   [2021]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/5] staging: vchiq: Make creation of vchiq cdev optional
On Tue, Jul 27, 2021 at 03:25:01PM +0200, Greg KH wrote:
> On Wed, Jul 21, 2021 at 09:50:52PM +0530, Ojaswin Mujoo wrote:
> > Before this commit, vchiq cdev (/dev/vchiq) was always created during
> > platform initialization. Introduce a new Kconfig option
> > CONFIG_VCHIQ_CDEV which determines if the cdev will be created or not.
> >
> > Signed-off-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> > ---
> > drivers/staging/vc04_services/Kconfig | 10 ++++++++++
> > drivers/staging/vc04_services/Makefile | 5 ++++-
> > .../vc04_services/interface/vchiq_arm/vchiq_arm.h | 9 +++++++++
> > 3 files changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig
> > index 4b886293f198..63caa6818d37 100644
> > --- a/drivers/staging/vc04_services/Kconfig
> > +++ b/drivers/staging/vc04_services/Kconfig
> > @@ -19,6 +19,16 @@ config BCM2835_VCHIQ
> > Defaults to Y when the Broadcom Videocore services
> > are included in the build, N otherwise.
> >
> > +if BCM2835_VCHIQ
> > +
> > +config VCHIQ_CDEV
> > + bool "VCHIQ Character Driver"
> > + help
> > + Enable the creation of VCHIQ character driver to help
> > + communicate with the Videocore platform.
>
> I'll take this, but this really should say more about what this really
> is for. Who needs this? Why will I know if I want a character driver
> interface? What tools talk to this?
>
> Or conversely, why would I want to turn this off?
>
> Can you send a follow-on patch that makes this more descriptive?
Hello Greg,

Sure, I can send in a follow up patch explaining this in more detail.

Thank you,
Ojaswin
>
> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2021-07-27 18:56    [W:0.056 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site