lkml.org 
[lkml]   [2021]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 06/17] r8152: Fix potential PM refcount imbalance
    Date
    From: Takashi Iwai <tiwai@suse.de>

    [ Upstream commit 9c23aa51477a37f8b56c3c40192248db0663c196 ]

    rtl8152_close() takes the refcount via usb_autopm_get_interface() but
    it doesn't release when RTL8152_UNPLUG test hits. This may lead to
    the imbalance of PM refcount. This patch addresses it.

    Link: https://bugzilla.suse.com/show_bug.cgi?id=1186194
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/usb/r8152.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
    index 95e27fb7d2c1..105622e1defa 100644
    --- a/drivers/net/usb/r8152.c
    +++ b/drivers/net/usb/r8152.c
    @@ -5282,9 +5282,10 @@ static int rtl8152_close(struct net_device *netdev)
    tp->rtl_ops.down(tp);

    mutex_unlock(&tp->control);
    + }

    + if (!res)
    usb_autopm_put_interface(tp->intf);
    - }

    free_all_mem(tp);

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-27 15:25    [W:2.770 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site