lkml.org 
[lkml]   [2021]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.13 04/21] ASoC: tlv320aic31xx: fix reversed bclk/wclk master bits
    Date
    From: Kyle Russell <bkylerussell@gmail.com>

    [ Upstream commit 9cf76a72af6ab81030dea6481b1d7bdd814fbdaf ]

    These are backwards from Table 7-71 of the TLV320AIC3100 spec [1].

    This was broken in 12eb4d66ba2e when BCLK_MASTER and WCLK_MASTER
    were converted from 0x08 and 0x04 to BIT(2) and BIT(3), respectively.

    -#define AIC31XX_BCLK_MASTER 0x08
    -#define AIC31XX_WCLK_MASTER 0x04
    +#define AIC31XX_BCLK_MASTER BIT(2)
    +#define AIC31XX_WCLK_MASTER BIT(3)

    Probably just a typo since the defines were not listed in bit order.

    [1] https://www.ti.com/lit/gpn/tlv320aic3100

    Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
    Link: https://lore.kernel.org/r/20210622010941.241386-1-bkylerussell@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/tlv320aic31xx.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/soc/codecs/tlv320aic31xx.h b/sound/soc/codecs/tlv320aic31xx.h
    index 81952984613d..2513922a0292 100644
    --- a/sound/soc/codecs/tlv320aic31xx.h
    +++ b/sound/soc/codecs/tlv320aic31xx.h
    @@ -151,8 +151,8 @@ struct aic31xx_pdata {
    #define AIC31XX_WORD_LEN_24BITS 0x02
    #define AIC31XX_WORD_LEN_32BITS 0x03
    #define AIC31XX_IFACE1_MASTER_MASK GENMASK(3, 2)
    -#define AIC31XX_BCLK_MASTER BIT(2)
    -#define AIC31XX_WCLK_MASTER BIT(3)
    +#define AIC31XX_BCLK_MASTER BIT(3)
    +#define AIC31XX_WCLK_MASTER BIT(2)

    /* AIC31XX_DATA_OFFSET */
    #define AIC31XX_DATA_OFFSET_MASK GENMASK(7, 0)
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-27 15:21    [W:5.162 / U:1.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site