Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 27 Jul 2021 13:39:45 +0200 | Subject | Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures |
| |
Hi Javier,
On Tue, Jul 27, 2021 at 1:32 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > On 7/27/21 1:17 PM, Geert Uytterhoeven wrote: > >> Not enabling this, would mean that a platform device to match a driver > >> supporting the EFI GOP framebuffer (e.g: simple{drm,fb} or efifb) will > >> not be registered. Which will lead to not having an early framebuffer. > > > > Do all (embedded) EFI systems have a frame buffer? > > That's a good question. I don't know if all EFI firmwares are expected > to provide a GOP or not. But even the u-boot EFI stub provides one, if > video output is supported by u-boot on that system. > > > Perhaps SYSFB should be selected by SYSFB_SIMPLEFB, FB_VESA, > > and FB_EFI? > > It's another option, yes. I just thought that the use of select was not > encouraged and using depends was less fragile / error prone.
Select is very useful for config symbols that are invisible to the user (i.e. cannot be enabled/disabled manually).
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |