Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH v3] rtw88: Remove unnecessary check code | Date | Tue, 27 Jul 2021 09:34:26 +0300 |
| |
Len Baker <len.baker@gmx.com> writes:
> The rtw_pci_init_rx_ring function is only ever called with a fixed > constant or RTK_MAX_RX_DESC_NUM for the "len" argument. Since this > constant is defined as 512, the "if (len > TRX_BD_IDX_MASK)" check > can never happen (TRX_BD_IDX_MASK is defined as GENMASK(11, 0) or in > other words as 4095). > > So, remove this check. > > Signed-off-by: Len Baker <len.baker@gmx.com>
Are everyone ok with this version?
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |